feat(styles): updated float utility #3752
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
🦋 Changeset detectedLatest commit: 8289085 The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Related Previews |
myrta2302
changed the title
oliverschuerch
requested changes
Oct 16, 2024
packages/documentation/src/stories/utilities/float/float.docs.mdx
Outdated
Show resolved
Hide resolved
packages/documentation/src/stories/utilities/float/float.docs.mdx
Outdated
Show resolved
Hide resolved
packages/documentation/src/stories/utilities/float/float.module.scss
Outdated
Show resolved
Hide resolved
packages/documentation/src/stories/utilities/float/float.stories.ts
Outdated
Show resolved
Hide resolved
packages/documentation/src/stories/utilities/float/float.stories.ts
Outdated
Show resolved
Hide resolved
packages/documentation/src/stories/utilities/float/float.stories.ts
Outdated
Show resolved
Hide resolved
packages/documentation/src/stories/utilities/float/float.snapshot.stories.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Oliver Schürch <[email protected]>
Co-authored-by: Oliver Schürch <[email protected]>
…esign-system into 3647-utilities-float
oliverschuerch
requested changes
Oct 17, 2024
packages/documentation/src/stories/utilities/float/float.stories.ts
Outdated
Show resolved
Hide resolved
packages/documentation/src/stories/utilities/float/float.stories.ts
Outdated
Show resolved
Hide resolved
packages/documentation/src/stories/utilities/float/float.stories.ts
Outdated
Show resolved
Hide resolved
|
oliverschuerch
requested changes
Oct 18, 2024
| }, | ||
| decorators: [ | ||
| (story: StoryFn, context: StoryContext) => { | ||
| const storyTemplate = html`<div class="clearfix float-example"> |
There was a problem hiding this comment.
Please remove this obsolete class
Suggested change
| const storyTemplate = html`<div class="clearfix float-example"> | |
| const storyTemplate = html`<div class="clearfix"> |
|
|
||
| return html` | ||
| <div class="${floatClass}"> | ||
| Sample Text ${args.floatPosition ? '(float-' + args.floatPosition + ')' : ''} |
There was a problem hiding this comment.
Sorry for adding a CR for this again, but it would be helpful to also know on which breakpoint the content should be floated.
Suggested change
| Sample Text ${args.floatPosition ? '(float-' + args.floatPosition + ')' : ''} | |
| Content ${floatClass ? '(' + floatClass + ')' : ''} |
| it('float', () => { | ||
| cy.visit('/iframe.html?id=snapshots--float'); | ||
| cy.get('.float-example', { timeout: 30000 }).should('be.visible'); | ||
| cy.percySnapshot('Float', { widths: [320, 1440] }); |
There was a problem hiding this comment.
Suggested change
| cy.percySnapshot('Float', { widths: [320, 1440] }); | |
| cy.percySnapshot('Float', { widths: [320, 400, 600, 780, 1024, 1280, 1440] }); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.